Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelpScout: clicking outside when inside an externally loaded app does not close the modal #798

Closed
sohkai opened this issue May 22, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@sohkai
Copy link
Member

commented May 22, 2019

I imagine the click event might not be bubbling outside of the iframe... in that case we may want to disable the click outside behaviour entirely.

@dizzypaty

This comment has been minimized.

Copy link
Member

commented May 28, 2019

The expected behavior is to actually close the Help Scout module when users click anywhere in the UI, that being inside an externally loaded app, system app or any other part of the client UI. The rational being that this help component should be as unobtrusive as possible.

I understand there might be some technical limitations with detecting click events outside the iframe, but @bpierre was suggesting that we could investigate more on the focus approach that he used on the popover.

@AquiGorka

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Hmmm, good idea, I will try and see if the useOnBlur hook I implemented can help with this.

@AquiGorka

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Closing as a solution was implemented: #828

@AquiGorka AquiGorka closed this Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.