Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt-in for Sentry bug reporting #858

Open
sohkai opened this issue Jul 3, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@sohkai
Copy link
Member

commented Jul 3, 2019

Upon hitting the global error handler, ask users if they'd like to opt-in to sending error reports with Sentry.

@sohkai sohkai added the enhancement label Jul 3, 2019

@luisivan

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

I suggest:

  1. Using NPM's version of Sentry's library, so we don't load an external, dynamic JS library for security reasons. Reference
  2. Catching the errors before initializing Sentry, and only load it when the user chooses to report. Then we can show their default error reporting dialog with showReportDialog. This should be good for the first version. Reference

We could do exactly the same for all the apps, or even automatically inject Sentry and initialize error handling when AragonApp is instantiated. Although I guess different devs will want their own reporting, so I think we should just do this on Aragon One's maintained apps.

luisivan added a commit that referenced this issue Jul 9, 2019

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

We could do exactly the same for all the apps, or even automatically inject Sentry and initialize error handling when AragonApp is instantiated.

Good point, I haven't though about how apps would do error reporting.

Would the UX be too bad if each app were to ask the user if they could send analytics / bug reports? It's what desktop / mobile apps do, and I understand why:

  • Different app developers may want to use different services
  • It's more or less impossible to stop an app developer from doing this without requesting user approval anyway (so we can't protect it via a client permission)
@luisivan

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Agree. We could have a consistent error reporting experience across apps maintained by us, but there is no way to enforce this for all of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.