Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: bring back to feature parity with old version #1005

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 10, 2019

Also adds a few stylistic changes as noted by @dizzypaty.

Features:

  • Context menu actions
  • Show unassigned roles in app view

All "entities" are now being shown as IdentityBadges:

Screen Shot 2019-09-10 at 1 27 58 PM

sohkai added 4 commits Sep 10, 2019

@auto-assign auto-assign bot requested review from AquiGorka and bpierre Sep 10, 2019

actions.push([
handleManageRole,
IconEdit,
entities.length > 0 ? 'Re-initialize permission' : 'Create permission',

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 10, 2019

Author Member

@dizzypaty I've taken the liberty to make this a bit closer to their technical reality rather than "Set manager"

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 10, 2019

Member

Is it important for the user to know that? Just wondering if they would know what initializing a permission means.

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 10, 2019

Author Member

Probably not, but "Set permission" is also inaccurate because this action also forces you to grant a permission.

{app && (
<AppInstanceLabel app={app} proxyAddress={app.proxyAddress} />
)}
</Field>

<Field label="Action description">{role && role.name}</Field>
<Field label="Permission">

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 10, 2019

Author Member

@dizzypaty I've changed this to be "Permission" instead of "Action" since "Action" is repeated below

This comment has been minimized.

Copy link
@dizzypaty

dizzypaty Sep 10, 2019

Member

I think this is ok and we can revisit this terminology after the launch and some user validation. I feel strongly about calling it 'Action' rather than 'Permission' because I understand the permission as the composition of 4 elements: 'On app' + 'Action' + 'Assigned to entity' + 'Managed by' = Permission.

Also, for consistency purposes, do you reckon that we should change 'Action' to 'Permission' on the available permissions table to match the title on the side panel?

@bpierre
Copy link
Member

left a comment

👍

actions.push([
handleManageRole,
IconEdit,
entities.length > 0 ? 'Re-initialize permission' : 'Create permission',

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 10, 2019

Member

Is it important for the user to know that? Just wondering if they would know what initializing a permission means.

@sohkai sohkai requested a review from dizzypaty Sep 10, 2019

@dizzypaty
Copy link
Member

left a comment

💙🚀💙🚀💙🚀💙

@dizzypaty

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

As a side note for after the launch: we could try to prefill some of the inputs when we know the context of the action. For example, when assigning a new permission that is currently assigned to multiple entities, or when we create a new permission from the app's permission view, in both cases we could prefill the 'On app' input.

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

We could try to prefill some of the inputs when we know the context of the action.

Yes! This would be really nice to do, but I didn't come up with a fast way of doing it right now :).

@now now bot requested a deployment to staging Sep 10, 2019 Abandoned

@sohkai sohkai merged commit f47dfbf into master Sep 10, 2019

3 of 7 checks passed

install install
Details
now Deployment has failed
Details
License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the permissions-update branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.