Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: remove preferences having empty tabs in small viewports #1006

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 10, 2019

Replaces the Preferences' tab bar with a visually similar version when there's only one item.

This is just for now; we should eventually handle this better in aragonUI: aragon/aragon-ui#595.

Currently:

Screen Shot 2019-09-10 at 1 48 13 PM

With the change:

Screen Shot 2019-09-10 at 1 46 29 PM

@dizzypaty

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019



<Tabs
items={tabItems}
onChange={onNavigation}
selected={sectionIndex}

This comment has been minimized.

Copy link
@AquiGorka

AquiGorka Sep 10, 2019

Member

When there is only 1 item this sectionIndex was not being set correctly, no need for the other changes if we set this correctly.

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 10, 2019

Author Member

There are a few problems with passing the correct sectionIndex for now, since the tab change handler is still firing with the assumption that all the tabs are available (clicking on "Network" changes the URL to custom labels).

I think this should be fixed once we disable the Tabs component when it only receives one item.

@sohkai sohkai merged commit e18f13f into master Sep 10, 2019

9 checks passed

build build
Details
install install
Details
lint lint
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@delete-merged-branch delete-merged-branch bot deleted the onboarding-preferences-tabs branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.