Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the full abi for the eventsource #1007

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@2color
Copy link
Contributor

commented Sep 10, 2019

What

  • Submit the ABI with all events when creating a subscription.

Why

  • The ABI is used to create eventsources which are shared across subscriptions for polling events. Because subscriptions can be to unique events, we need to have the ABI with all the events.

@auto-assign auto-assign bot requested review from AquiGorka, bpierre and sohkai Sep 10, 2019

@sohkai
sohkai approved these changes Sep 10, 2019
Copy link
Member

left a comment

@2color 2color merged commit d627eb4 into master Sep 10, 2019

7 of 9 checks passed

build build
Details
install install
Details
lint lint
Details
License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP Ready for review
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@delete-merged-branch delete-merged-branch bot deleted the notifications-full-events-abi branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.