Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountModule: initial version without popover #1014

Merged
merged 8 commits into from Sep 10, 2019

Conversation

@bpierre
Copy link
Member

commented Sep 10, 2019

No description provided.

@bpierre bpierre requested review from sohkai and dizzypaty Sep 10, 2019

@auto-assign auto-assign bot requested a review from AquiGorka Sep 10, 2019

@bpierre bpierre requested a review from luisivan Sep 10, 2019

@dizzypaty
Copy link
Member

left a comment

🤩🤩🤩🤩🤩🤩
🤩🤩🤩🤩🤩🤩
🤩🤩🤩🤩🤩🤩

@sohkai
sohkai approved these changes Sep 10, 2019
Copy link
Member

left a comment

🏁 LGTM!

@bpierre I've added a few more commits to use this new provider in more places :).

@bpierre

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

@sohkai I think you need to run $ git push the few commits I added

@now now bot requested a deployment to staging Sep 10, 2019 Abandoned

@now now bot requested a deployment to staging Sep 10, 2019 Abandoned

@sohkai

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@bpierre now ready :).

@bpierre

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

@sohkai Super nice 🤗

bpierre added 3 commits Sep 10, 2019

@now now bot requested a deployment to staging Sep 10, 2019 Abandoned

@bpierre bpierre merged commit 05057d3 into master Sep 10, 2019

2 of 6 checks passed

install install
Details
now Deployment has failed
Details
License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Ready for review
Details

@delete-merged-branch delete-merged-branch bot deleted the account-module branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.