Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "?" redirection on Chrome #1020

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@bpierre
Copy link
Member

commented Sep 10, 2019

馃檲 馃檲 馃檲

@bpierre bpierre requested review from AquiGorka and sohkai Sep 10, 2019

event.preventDefault()
const error = validationError(tokenName, tokenSymbol, members)
setFormError(error)
if (!error) {

This comment has been minimized.

Copy link
@AquiGorka

AquiGorka Sep 10, 2019

Member

Nitpick:

if (error) {
   return
}
next({ /**/ })
@AquiGorka
Copy link
Member

left a comment

鉂わ笍 event.preventDefault 馃帀

@sohkai
sohkai approved these changes Sep 10, 2019
Copy link
Member

left a comment

馃憤 馃憤 馃憤

@luisivan luisivan merged commit 84116fb into master Sep 10, 2019

4 of 9 checks passed

lint lint
Details
build build
Details
install install
Details
now Deployment has failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-chrome-redirection branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.