Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: error modal #1033

Merged
merged 7 commits into from Sep 10, 2019

Conversation

@bpierre
Copy link
Member

commented Sep 10, 2019

@sohkai It restarts from the first signature whenever it fails. Do you think it should resume from the failed one?

@bpierre bpierre requested review from AquiGorka and sohkai Sep 10, 2019

@@ -279,6 +282,10 @@ function useDeploymentState(
}, Promise.resolve())
}
createTransactions()

return () => {
cancelled = true

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 10, 2019

Author Member

@sohkai Also this seemed to be missing

src/onboarding2/Create/Create.js Outdated Show resolved Hide resolved
src/onboarding2/Create/Create.js Outdated Show resolved Hide resolved

@now now bot temporarily deployed to staging Sep 10, 2019 Inactive

@now now bot temporarily deployed to staging Sep 10, 2019 Inactive

Update src/onboarding2/Create/Create.js
Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>
if (!cancelled) {
deployTransactions
// If we're retrying, only retry from the last signed one
.slice(transactionProgress.signed)

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 10, 2019

Author Member

🎯

@bpierre bpierre merged commit dddcf71 into master Sep 10, 2019

8 of 9 checks passed

build build
Details
install install
Details
lint lint
Details
License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@delete-merged-branch delete-merged-branch bot deleted the onboarding-error-modal branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.