Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding welcome: UI fixes #1110

Merged
merged 4 commits into from Oct 9, 2019

Conversation

@bpierre
Copy link
Member

commented Oct 9, 2019

No description provided.

bpierre added 2 commits Oct 9, 2019
@bpierre bpierre requested a review from sohkai Oct 9, 2019

{suggestedOrgs.length > 0 ? (

This comment has been minimized.

Copy link
@sohkai

sohkai Oct 9, 2019

Member

Not sure I understand this change; shouldn't we only not show <Suggestions> if suggestedOrgs.length === 0?

Ahh nevermind, I see that we just show the primary content otherwise.

@sohkai
sohkai approved these changes Oct 9, 2019
Copy link
Member

left a comment

LGTM, I just noticed something weird with rinkeby (that's likely been a problem since 0.8 launched):

Screen Shot 2019-10-09 at 3 43 41 PM

Fixed in #1111

@bpierre bpierre merged commit 6a970bc into master Oct 9, 2019
5 checks passed
5 checks passed
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
now Deployment has completed
Details
@delete-merged-branch delete-merged-branch bot deleted the onboarding-welcome-fixes branch Oct 9, 2019
@AquiGorka AquiGorka referenced this pull request Oct 10, 2019
17 of 64 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.