Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites: display identicons for known orgs #1111

Merged
merged 4 commits into from Oct 9, 2019

Conversation

@sohkai
Copy link
Member

commented Oct 9, 2019

Abstracts the organization image into an OrgIcon component, similar to AppIcon.

Also fixes a few small things with alignments / etc.

Screen Shot 2019-10-09 at 4 33 25 PM

sohkai added 3 commits Oct 9, 2019
{knownOrg ? (
<img
src={knownOrg.image}
width={6 * GU}

This comment has been minimized.

Copy link
@sohkai

sohkai Oct 9, 2019

Author Member

These items used to "say" they were 6 GU, but were in reality only 3 GU (because of the width: 100%), and the designs are also 3.

@sohkai sohkai requested a review from bpierre Oct 9, 2019
@bpierre
bpierre approved these changes Oct 9, 2019
Copy link
Member

left a comment

LGTM 🙏

height={size}
alt=""
css={`
object-fit: contain;

This comment has been minimized.

Copy link
@bpierre

bpierre Oct 9, 2019

Member

We could inline this ✂️

This comment has been minimized.

Copy link
@sohkai

sohkai Oct 9, 2019

Author Member

Fixed in d13b8c3.

@sohkai sohkai merged commit 77e44a7 into onboarding-welcome-fixes Oct 9, 2019
2 of 6 checks passed
2 of 6 checks passed
License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
now Now is deploying your app
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@sohkai sohkai deleted the favorites-org-icons branch Oct 9, 2019
bpierre added a commit that referenced this pull request Oct 9, 2019
- Don’t display the suggestions when empty.
- Fix layout between small and medium breakpoints.
- Favorites: display identicons for known orgs (#1111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.