Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: clamp value of Voting's support and quorum to their max values #1114

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@sohkai
Copy link
Member

commented Oct 9, 2019

Fixes #1070. Clamps the support and quorum values to be 1e18 (100%) - 1.

The Voting app's frontend is even smart enough to know this is 100% 馃槃:

Screen Shot 2019-10-09 at 7 56 25 PM

鈥lues
@sohkai sohkai requested a review from bpierre Oct 9, 2019
@@ -17,6 +17,24 @@ function completeDomain(domain) {
return domain ? `${domain}.aragonid.eth` : ''
}

function adjustVotingSettings(support, quorum) {

This comment has been minimized.

Copy link
@sohkai

sohkai Oct 9, 2019

Author Member

I had a thought that maybe we should put this logic into the VotingScreen (and the similar logic for the TokenScreen)... but then decided that it might make more sense to keep the logic in each template since they know better than the VotingScreen what their limits are.

Copy link
Member

left a comment

LGTM!

@sohkai sohkai merged commit 02f07ab into master Oct 10, 2019
6 checks passed
6 checks passed
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details
@delete-merged-branch delete-merged-branch bot deleted the onboarding-fix-voting-100 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.