New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `start_url` filtering #161

Merged
merged 2 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@onbjerg
Contributor

onbjerg commented Mar 20, 2018

We're filtering out all the apps because it filters for short_url, but it's actually called start_url.

Furthermore, I think we should default to /index.html as opposed to filtering out the app.

@onbjerg onbjerg added the bug label Mar 20, 2018

@onbjerg onbjerg requested review from bpierre and sohkai Mar 20, 2018

@onbjerg

This comment has been minimized.

Show comment
Hide comment
@onbjerg

onbjerg Mar 20, 2018

Contributor

If this was intended to filter out apps without frontends, then we should probably filter it based on something else -- I am not sure what, though.

Contributor

onbjerg commented Mar 20, 2018

If this was intended to filter out apps without frontends, then we should probably filter it based on something else -- I am not sure what, though.

@sohkai

sohkai approved these changes Mar 20, 2018

@onbjerg

This comment has been minimized.

Show comment
Hide comment
@onbjerg

onbjerg Mar 20, 2018

Contributor

Per my last comment I changed it to filter based on start_url with no default.

Contributor

onbjerg commented Mar 20, 2018

Per my last comment I changed it to filter based on start_url with no default.

@bpierre

👌

@onbjerg onbjerg merged commit 359f0d6 into master Mar 20, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai changed the title from Default `start_url` to `index.html` to Fix `start_url` filtering Mar 20, 2018

@sohkai sohkai deleted the fix-app-filtering branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment