Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WalletWeb3: always pass down resolved instance rather than use environment's #546

Merged
merged 1 commit into from Dec 16, 2018
Merged

WalletWeb3: always pass down resolved instance rather than use environment's #546

merged 1 commit into from Dec 16, 2018

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Dec 14, 2018 •
edited

Builds on #469

Always uses the passed down walletWeb3 instance.

Also removes some unnecessary default props.

@sohkai sohkai requested a review from bpierre December 14, 2018 19:02
bpierre
bpierre approved these changes Dec 15, 2018
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌

It could be useful to have a provider for this (later).

@sohkai
Copy link
Contributor Author

sohkai commented Dec 16, 2018

It could be useful to have a provider for this (later).

Absolutely, and along with a number of other things (e.g. locator) :)!

@sohkai sohkai merged commit cbfe49a into eth-provider Dec 16, 2018
@sohkai sohkai deleted the walletweb3-cleanup branch December 16, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sohkai @bpierre