Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local identities #656

Merged
merged 107 commits into from Mar 29, 2019

Conversation

Projects
None yet
6 participants
@AquiGorka
Copy link
Contributor

AquiGorka commented Mar 20, 2019

This PR aggregates changes from:

Accompanying apps PRs:

Todo

  • Bump minor version of @aragon/ui once released with updated IdentityBadge
  • Bump version of @aragon/wrapper once released with identities functionality

@AquiGorka AquiGorka requested review from bpierre, 2color and sohkai Mar 20, 2019

@AquiGorka AquiGorka force-pushed the feature/local-identities branch 2 times, most recently from 211cb3a to 23a5593 Mar 20, 2019

@AquiGorka AquiGorka referenced this pull request Mar 20, 2019

Merged

Token manager: custom labels #722

2 of 2 tasks complete

@2color 2color referenced this pull request Mar 21, 2019

Merged

Voting: Custom Labels / Local Identities #728

2 of 2 tasks complete
Show resolved Hide resolved src/App.js
Show resolved Hide resolved src/App.js
Show resolved Hide resolved src/App.js Outdated
Show resolved Hide resolved src/App.js Outdated

@2color 2color force-pushed the feature/local-identities branch from 8710186 to 7e66452 Mar 22, 2019

@2color

This comment has been minimized.

Copy link
Contributor

2color commented Mar 22, 2019

I'm getting the following error when interacting with identities in the native setting apps

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
in Modal (created by Spring)
in div (created by AnimatedComponent)
in AnimatedComponent (created by ForwardRef)
in ForwardRef (created by Context.Consumer)
in StyledComponent (created by ModalManager__AnimatedWrap)
in ModalManager__AnimatedWrap (created by Spring)
in div (created by Context.Consumer)
in StyledComponent (created by ModalManager__Wrap)
in ModalManager__Wrap (created by Spring)
in Spring (created by KeyframesImpl)
in KeyframesImpl (created by ForwardRef)
in ForwardRef (created by Transition)

Steps to recreate:

  1. Click on a badge
  2. Edit label
  3. Save
  4. Repeat first three steps
  5. See error after the second save

Leaving this comment so I can debug later.

@AquiGorka

This comment has been minimized.

Copy link
Contributor Author

AquiGorka commented Mar 25, 2019

Memory leaked fixed in c6741b2

@2color 2color self-requested a review Mar 25, 2019

@2color

2color approved these changes Mar 25, 2019

Copy link
Contributor

2color left a comment

Looking great!

Show resolved Hide resolved src/components/MenuPanel/MenuPanel.js Outdated
Show resolved Hide resolved src/components/Preferences/Preferences.js Outdated
Show resolved Hide resolved src/components/Preferences/Preferences.js
Show resolved Hide resolved src/components/Preferences/Preferences.js Outdated
Show resolved Hide resolved src/components/Preferences/Preferences.js Outdated
Show resolved Hide resolved src/components/LocalIdentityModal/LocalIdentityModal.js Outdated
Show resolved Hide resolved src/components/LocalIdentityModal/LocalIdentityModal.js Outdated
Show resolved Hide resolved src/components/LocalIdentityModal/LocalIdentityModal.js Outdated
Show resolved Hide resolved src/components/LocalIdentityModal/LocalIdentityModal.js
Show resolved Hide resolved src/components/App/AppIFrame.js

@bpierre bpierre referenced this pull request Mar 25, 2019

Merged

Finance: custom labels #700

2 of 2 tasks complete

@AquiGorka AquiGorka force-pushed the feature/local-identities branch from ea5260f to 69c6b71 Mar 29, 2019

@2color

2color approved these changes Mar 29, 2019

@AquiGorka AquiGorka merged commit 77e1225 into master Mar 29, 2019

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@AquiGorka AquiGorka deleted the feature/local-identities branch Mar 29, 2019

@AquiGorka AquiGorka referenced this pull request Mar 29, 2019

Closed

Address comments on Local Identities first iteration #672

3 of 3 tasks complete

2color added a commit that referenced this pull request Apr 3, 2019

Merge remote-tracking branch 'origin/master' into activity-panel
* origin/master: (56 commits)
  Identity - Improve LocalIdentityBadge (#673)
  Menu panel footer separator (#666)
  fix(MenuPanel): avoid clickable margin above system apps toggle (#671)
  Local identities (#656)
  MenuPanel: add toggle animation to show/hide system apps (#658)
  Add github workflow for linting/building (#663)
  Permissions: added system and background app labels (#650)
  Use the same component to render every app icon (#655)
  chore: add all contributors and contributing guidelines (#649)
  Manage the menu button using messages + prevent re-mounting on resize (#651)
  Update melon (#647)
  Apps <> System apps separator (#648)
  Upgrade lint-staged (#646)
  fix: always leave Kernel as first app (#645)
  fix: avoid assigning a registry tag if app is not on a registry (#644)
  chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639)
  DaoSettings: add bottom margin on app items (#638)
  Refactor common components (#615)
  Enforce MenuPanel’s width (#636)
  Menu panel swipe open close (#606)
  ...

2color added a commit that referenced this pull request Apr 3, 2019

Merge remote-tracking branch 'origin/master' into notifications
* origin/master: (55 commits)
  Identity - Improve LocalIdentityBadge (#673)
  Menu panel footer separator (#666)
  fix(MenuPanel): avoid clickable margin above system apps toggle (#671)
  Local identities (#656)
  MenuPanel: add toggle animation to show/hide system apps (#658)
  Add github workflow for linting/building (#663)
  Permissions: added system and background app labels (#650)
  Use the same component to render every app icon (#655)
  chore: add all contributors and contributing guidelines (#649)
  Manage the menu button using messages + prevent re-mounting on resize (#651)
  Update melon (#647)
  Apps <> System apps separator (#648)
  Upgrade lint-staged (#646)
  fix: always leave Kernel as first app (#645)
  fix: avoid assigning a registry tag if app is not on a registry (#644)
  chore: upgrade @aragon/wrapper to v4.0.0-beta.1 (#639)
  DaoSettings: add bottom margin on app items (#638)
  Refactor common components (#615)
  Enforce MenuPanel’s width (#636)
  Menu panel swipe open close (#606)
  ...
left: 2px;
`}
/>
<IdentityBadge entity="Address badge" />

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 4, 2019

Member

Seems like we should add a way to stop the popover from activating @bpierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.