Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization switcher: open or create another org #665

Merged
merged 6 commits into from Apr 5, 2019

Conversation

Projects
None yet
5 participants
@bpierre
Copy link
Member

bpierre commented Mar 28, 2019

Fixes #568

Preview


Normal state


Focused state

Changes

  • Add an item to open or create another organization by redirecting to the home screen.
  • Move the common focus logic and styling in ItemButton.

Notes

  • The correct label should be something like “Create or open another organization”, but “Open organization…” was chosen to keep it shorter.
  • The “…” were used to make it clearer that it is a clickable item, but maybe an icon could do a better job at it? Edit: done, thanks @dizzypaty!
Organization switcher: open or create another org
- Add an item to open or create another organization by redirecting to the
  home screen.
- Move the common focus logic and styling in `ItemButton`.

@bpierre bpierre requested review from sohkai and dizzypaty Mar 28, 2019

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Mar 28, 2019

The “…” were used to make it clearer that it is a clickable item, but maybe an icon could do a better job at it?

Agreed, I do find this a bit confusing (it also looks odd since it doesn't have a header). Maybe we could use an arrow or etc @dizzypaty?

@bpierre bpierre requested a review from AquiGorka Mar 28, 2019

@dizzypaty

This comment has been minimized.

Copy link
Member

dizzypaty commented Mar 28, 2019

The “…” were used to make it clearer that it is a clickable item, but maybe an icon could do a better job at it?

Agreed, I do find this a bit confusing (it also looks odd since it doesn't have a header). Maybe we could use an arrow or etc @dizzypaty?

@sohkai @bpierre

I've tried a few options with possible icons, but my preference is to just add a divider to separate this action from the organizations list. It feels cleaner because the identicons are already visually quite heavy.

@luisivan

This comment has been minimized.

Copy link
Member

luisivan commented Apr 5, 2019

@dizzypaty I like the "Open organization" with the + icon. In that context, it's like adding an org to your list, so it's very understandable. Let's do that

@bpierre bpierre requested a review from 2color Apr 5, 2019

bpierre added some commits Apr 5, 2019

@bpierre bpierre requested a review from sohkai Apr 5, 2019

@sohkai

sohkai approved these changes Apr 5, 2019

Copy link
Member

sohkai left a comment

@bpierre Should the "Open organization" have a bottom border applied to it?

@bpierre

This comment has been minimized.

Copy link
Member Author

bpierre commented Apr 5, 2019

@sohkai oh yes totally forgot to add it, thanks!

@bpierre bpierre merged commit 5ba750e into master Apr 5, 2019

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@bpierre bpierre deleted the open-another-organization branch Apr 5, 2019

2color added a commit that referenced this pull request Apr 8, 2019

Merge remote-tracking branch 'origin/master' into activity-panel
* origin/master:
  Organization switcher: open or create another org (#665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.