Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Provider: provide response to aragonAPI when user cancels identity modification #686

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

commented Apr 9, 2019

Coupled with aragon/aragon.js#277, apps will now receive errors on requestAddressIdentityModification().

@sohkai sohkai requested review from bpierre and 2color Apr 9, 2019

this.setState({ identityIntent: null }, identityIntent.resolve)
)
.then(identityIntent.resolve)
.then(() => this.setState({ identityIntent: null }))

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 9, 2019

Author Member

I think it's more clear this way (it also propagates the returned metadata to requestAddressIdentityModification()), but perhaps there was a reason for doing the resolution in the setState() callback?

This comment has been minimized.

Copy link
@2color

2color Apr 10, 2019

Contributor

I agree. I don't believe there was a reason.

@2color

2color approved these changes Apr 10, 2019

@sohkai sohkai merged commit 037a05f into master Apr 10, 2019

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the identity-intent-response branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.