Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restart app worker when upgraded #688

Merged
merged 5 commits into from Apr 14, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

sohkai commented Apr 10, 2019

Coupled with aragon/aragon.js#267, this allows the client to restart an upgraded app's worker in-place.

We reset the cache on the upgrade as well, as there may be incompatibilities in the reduced state between different worker versions (as well as paired with their frontends). Note that app frontends are handled mostly transparently as we re-load their URL into the iframe upon navigation.

sohkai added some commits Apr 10, 2019

@sohkai sohkai requested review from bpierre and 2color Apr 10, 2019

@2color

2color approved these changes Apr 12, 2019

Copy link
Contributor

2color left a comment

LGTM.

👌🏽for separating out all DAO specific initial state. It might be good to move it into a context eventually.

@sohkai sohkai merged commit e8cd486 into app-center Apr 14, 2019

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the restart-app-worker branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.