Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current account with connect account button #693

Merged
merged 6 commits into from Apr 15, 2019

Conversation

Projects
None yet
4 participants
@2color
Copy link
Contributor

2color commented Apr 12, 2019

What

  • A current account button which displays the currently connected account
  • When no account has been connected, a button to connect will be rendered

Screenshots

Enable account

Screen Shot 2019-04-12 at 7 27 20 pm

Account enabled

Screen Shot 2019-04-12 at 7 27 27 pm

With local identity

Screen Shot 2019-04-12 at 7 31 22 pm

@2color 2color requested review from bpierre, sohkai and dizzypaty Apr 12, 2019

@bpierre
Copy link
Member

bpierre left a comment

🚀

<div
css={`
display: flex;
align-items: center;

This comment has been minimized.

Copy link
@bpierre

bpierre Apr 12, 2019

Member

Is it not centered properly without this?

This comment has been minimized.

Copy link
@2color

2color Apr 15, 2019

Author Contributor

It's centred just fine without the two css props so I'll removed it.

I think it's also not required on the PreferencesButton component. Any thoughts?

@dizzypaty
Copy link
Member

dizzypaty left a comment

🚀🚀🚀 Fantastic job Daniel! 🚀🚀🚀

@sohkai

sohkai approved these changes Apr 12, 2019

Copy link
Member

sohkai left a comment

❤️

2color added some commits Apr 15, 2019

Show resolved Hide resolved src/Wrapper.js Outdated
@sohkai

sohkai approved these changes Apr 15, 2019

@sohkai sohkai merged commit 3200cda into master Apr 15, 2019

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the add-current-account branch Apr 15, 2019

2color added a commit that referenced this pull request Apr 16, 2019

Merge remote-tracking branch 'origin/master' into activity-panel
* origin/master:
  fix: align connect account with preferences button (#700)
  Fix import file button (#698)
  feat: add current account with connect account button (#693)
  feat: load app icon from new icon schema with size selector (#691)
  Discover Apps: update Espresso + Payroll icons (#696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.