Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure MenuPanel is only displayed when needed #695

Merged
merged 13 commits into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@bpierre
Copy link
Member

bpierre commented Apr 15, 2019

- Add a new state to App: daoStatus. Similar to appsStatus, but for the
  resolution of the DAO name. Add corresponding type (DaoStatusType) and
  symbols (DAO_STATUS_LOADING, etc.).
- In App, set daoStatus and appsStatus more consistently.
- Add a APPS_STATUS_UNLOADED state, instead of using APPS_STATUS_LOADING
  when no apps are being loaded. This prevents the loading indicator of
  the MenuPanel to be active.
- The Organization Switcher now only displays its loading indicator if
  daoStatus is DAO_STATUS_LOADING.
- Wrap Onboarding and Wrapper to set their z-index explicitly.
- CombinedPanel: ensure the overlay doesn’t flash while transitioning
  from static to autoclosing mode.
Ensure MenuPanel is only displayed when needed
- Add a new state to App: daoStatus. Similar to appsStatus, but for the
  resolution of the DAO name. Add corresponding type (DaoStatusType) and
  symbols (DAO_STATUS_LOADING, etc.).
- In App, set daoStatus and appsStatus more consistently.
- Add a APPS_STATUS_UNLOADED state, instead of using APPS_STATUS_LOADING
  when no apps are being loaded. This prevents the loading indicator of
  the MenuPanel to be active.
- The Organization Switcher now only displays its loading indicator if
  daoStatus is DAO_STATUS_LOADING.
- Wrap Onboarding and Wrapper to set their z-index explicitly.
- CombinedPanel: ensure the overlay doesn’t flash while transitioning
  from static to autoclosing mode.

@bpierre bpierre requested a review from sohkai Apr 15, 2019

bpierre added some commits Apr 15, 2019

@sohkai

sohkai approved these changes Apr 15, 2019

Copy link
Member

sohkai left a comment

❤️

src/App.js Outdated
<Wrapper
<div css="position: relative; z-index: 1">
<Wrapper
visible={mode === 'app'}

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 15, 2019

Member

It might be a good time to move these to be Symbols as well

sohkai added some commits Apr 16, 2019

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Apr 16, 2019

@bpierre I've just added a few commits:

  • b788452: Move the locator's modes to symbols (and rename the app mode to org and start instead of app and home 😄)
  • 70273e9: Probably due to a merge conflict, but fix the props passed down to Wrapper
  • 0d7a59c: move the web3 object creation up to App's constructor
  • ea05e60: fix the Preferences panel being rendered behind the MenuPanel

sohkai added some commits Apr 16, 2019

Show resolved Hide resolved src/App.js Outdated

2color and others added some commits Apr 16, 2019

Update src/App.js
Co-Authored-By: sohkai <qisheng.brett.sun@gmail.com>
@2color

2color approved these changes Apr 16, 2019

@bpierre bpierre merged commit 87d4030 into activity-panel Apr 16, 2019

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@bpierre bpierre deleted the activity-panel-fix-menupanel-display branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.