Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer Panel: Display token approval spender when used in pre-transaction #825

Merged
merged 5 commits into from Jul 10, 2019

Conversation

Projects
None yet
3 participants
@2color
Copy link
Contributor

commented Jun 5, 2019

What

When a pretransaction is required and there's a spender for defining a different address (as per aragon/aragon.js#321), render the address for the user to see.

This will only show the message when there's a spender meaning that the address is different to the app's

Sneak Peek

Screen Shot 2019-06-05 at 5 21 20 pm

@AquiGorka
Copy link
Member

left a comment

👌

@stale stale bot added the abandoned label Jul 5, 2019

@sohkai sohkai removed the abandoned label Jul 8, 2019

@aragon aragon deleted a comment from stale bot Jul 8, 2019

@sohkai sohkai changed the title Display spender in signer panel when used in pre-transaction Signer Panel: Display token approval spender when used in pre-transaction Jul 10, 2019

sohkai added some commits Jul 10, 2019

@sohkai

sohkai approved these changes Jul 10, 2019

Copy link
Member

left a comment

I've reverted the change to make it badgeOnly, because it's quite important to see the full address and inspect it in this case.

cc @dizzypaty There are a couple ways to improve this in the future, but let's wait for a redesign of the signing panel first:

  • Use AppBadge if the address is an installed app
  • Always provide a description of the pretransaction, even if it's not to another contract, but provide a stronger warning to the user if it's to a different contract

@sohkai sohkai merged commit 32c30cd into master Jul 10, 2019

3 of 6 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Ready for review
Details
install install
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the custom-approve-spender branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.