Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feat/profiles #847

Open
wants to merge 7 commits into
base: master
from

Conversation

@Schwartz10
Copy link
Contributor

commented Jun 22, 2019

Hello again!

This is a pretty small PR, but it gets the profile node module rendering in the aragon client when you run npm run start:with:profiles.

I messed around with rendering the profile in a special iframe, but I had some difficulties getting the css to display properly from within the iframe - i couldnt figure out an easy fix (there were some ideas i didn't try bc they required adding dependencies related to styled-components lib). If you know of one fix for this please let me know, and I'll implement!! I talked to @bpierre about this, and he said I could punt on it for now and revisit later as this code gets closer to becoming part of the client by default.

Instructions on running this code:

Instructions for running this branch. In your terminal, first clone the repo:
git clone git@github.com:openworklabs/aragon.git
cd aragon

Get the development branch:
git fetch origin feat/profiles
git checkout feat/profiles

install deps:
npm i

start the app:
npm run start:with:profiles

Navigate to http://localhost:3000/ and create an organization on rinkeby. Once on your organization, you have to manually navigate to profiles via the url bar:

Your profile:
http://localhost:3000/#/<ENS-NAME>/profile/

Someone else's profile:
http://localhost:3000/#/<ENS-NAME>/profile/<ETHEREUM-ADDRESS>

Example:
http://localhost:3000/#/schwartzzilla.aragonid.eth/profile/0x501D456ed92F1223D71208A8e6d3F77761174AF1

Some things left to do (which i think we can work towards in follow up PRs):

  • figure out how to use the app identity badge (or something similar) in the signing panel to show the aragon profile application requested a user's signature
  • match styles (like grid units, margins...etc) with native aragon designs
  • Come to an agreement on how to use the identity resolver with 3box (here was a conversation from a month ago on the topic)

@auto-assign auto-assign bot requested review from AquiGorka, bpierre and sohkai Jun 22, 2019

@sohkai sohkai changed the title Feat/profiles [WIP] Feat/profiles Jul 9, 2019

@stale stale bot added the abandoned label Aug 8, 2019

@aragon aragon deleted a comment from stale bot Aug 9, 2019

@stale stale bot removed the abandoned label Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.