Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/external txs #850

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Schwartz10
Copy link
Contributor

commented Jun 25, 2019

This is a PR to support #536 and goes along with aragon/aragon.js#328

Think we could do a better job with language, but this could be a starting point that we improve as we start to see new designs and more informative copy.

image

Also, I'm not sure why my linter complained about src/aragonjs-wrapper.js - i didnt touch that file?

@@ -115,6 +115,7 @@ class SignerPanel extends React.PureComponent {

return {
intent: (transaction && this.transactionIntent(bag)) || {},
external: transaction.external,

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 3, 2019

Member

Rather than encoding this information into the transaction object aragon.js sends, we could do a check here with transaction.to against the list installed apps to detect if it's an external transaction.

@sohkai sohkai requested review from dizzypaty and removed request for bpierre and AquiGorka Jul 3, 2019

@sohkai

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

@dizzypaty Let's discuss the copy / security concerns of what this means when you're ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.