Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: support Ropsten #866

Merged
merged 3 commits into from Jul 12, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

commented Jul 11, 2019

Adds support for Ropsten, and only shows the network as available in the onboarding selector if the client's been built for Ropsten.

cc @izqui

TODO:

  • Get deployed ENS address on Ropsten
  • Add details to arapp.json, scripts to package.json
  • Sanity check network details (e.g. URLs, etc)

@sohkai sohkai requested review from bpierre and AquiGorka Jul 11, 2019

@sohkai sohkai referenced this pull request Jul 11, 2019

Open

Deploy Aragon on Ropsten #152

Show resolved Hide resolved src/App.js Outdated

sohkai and others added some commits Jul 11, 2019

Update ropsten deployment URL
Co-Authored-By: Jorge Izquierdo <jorge@aragon.one>
Network: add Ropsten ENS address and scripts (#870)
* Network: add Ropsten ENS address and scripts

* Reorder publish scripts
@izqui

izqui approved these changes Jul 12, 2019

Copy link
Member

left a comment

Built it locally (passing an Infura endpoint as an env variable) to test it and everything is looking good

@izqui izqui marked this pull request as ready for review Jul 12, 2019

@izqui izqui merged commit 15ead6a into master Jul 12, 2019

8 checks passed

License Compliance All checks passed.
Details
WIP Ready for review
Details
build build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
install install
Details
license/cla Contributor License Agreement is signed.
Details
lint lint
Details

@delete-merged-branch delete-merged-branch bot deleted the ropsten branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.