Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy: deploy staging builds with now #867

Open
wants to merge 24 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@sohkai
Copy link
Member

commented Jul 11, 2019

A bit of a painful thing is that now uses yarn by default (no way to change this it seems), unless the repo has a package-lock.json included.

I've added the package-lock.json because now is hanging when using yarn. I've also removed @aragon/cli as a devDependency, as it was failing to install on subsequent runs, and instead added a prompt for the user to install it globally if they want to publish. This also decreases the install time of the repo significantly 馃槃. (cc @izqui @0xGabi)

Now is now working with yarn 馃帀.

Due to some limitations with the Github + now integration (it only supports one deployment), I've set up Travis to also deploy builds of each branch + master for mainnet. The Github + now integration is set up to deploy against rinkeby.


With web3@1.0.0 finally approaching soon, and us upgrading to beta.37 soon, we can revisit how well yarn / package-locks work.

@auto-assign auto-assign bot requested review from AquiGorka and bpierre Jul 11, 2019

@sohkai sohkai removed request for bpierre and AquiGorka Jul 11, 2019

@now now bot had a problem deploying to staging Jul 11, 2019 Failure

@AquiGorka

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

I cannot wait to have this, and then maybe we can work on having deployments for feature branches :)

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@AquiGorka If it works (not yet), it will be enabled by default on feature branches. We can also configure DNS to have it update a nightly build via merges to master.

For some reason yarn is hanging on the deployment (see support chat) whereas npm works with a package-lock.json.

It may be something funny with the go-ipfs dependency, and we can try this again once aragonCLI is installable via yarn, but we may have to go with committing package-lock.jsons for now.

sohkai added some commits Jul 11, 2019

@sohkai sohkai marked this pull request as ready for review Jul 11, 2019

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Updated the opening comment about the removal of @aragon/cli from devDependencies cc @izqui @0xGabi.

@0xGabi

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Great, considering the improve installation time I think is better to leave aragonCLI as optional.

As far a s I know only maintainers are going to publish the client?

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

As far a s I know only maintainers are going to publish the client?

Yes, and even less so with AGP-28 馃槃.

@AquiGorka
Copy link
Member

left a comment

馃帀 馃帀 馃槏
Quesstion: this implements the now-build script and the accompanying now.json but what where the changes for this to be triggered with merges top master and pushes to branches?

Update: I think is has to do with the now bot you mentioned yesterday, will look into it :)

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

@now now bot temporarily deployed to staging Jul 16, 2019 Inactive

@sohkai

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

Now now seems to be able to deploy this via yarn 馃帀.

sohkai added some commits Jul 17, 2019

sohkai added some commits Jul 17, 2019

@now now bot had a problem deploying to staging Jul 17, 2019 Failure

@now now bot temporarily deployed to staging Jul 17, 2019 Inactive

@now now bot temporarily deployed to staging Jul 17, 2019 Inactive

@now now bot temporarily deployed to staging Jul 17, 2019 Inactive

Revert "Travis: use trusty"
This reverts commit a0fa8bf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.