Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: add Ropsten ENS address and scripts #870

Merged
merged 2 commits into from Jul 12, 2019

Conversation

Projects
None yet
2 participants
@izqui
Copy link
Member

commented Jul 11, 2019

Deployment for Ropsten is underway (aragon/deployments#103) and ENS is already deployed for the network

@izqui izqui requested a review from sohkai Jul 11, 2019

@auto-assign auto-assign bot requested review from AquiGorka and bpierre Jul 11, 2019

@sohkai

sohkai approved these changes Jul 11, 2019

Copy link
Member

left a comment

👍 👍 👍

@@ -107,7 +109,10 @@
"publish:staging:patch": "npm run publish:patch -- --environment staging --build-script build:staging",
"publish:mainnet:major": "npm run publish:major -- --environment mainnet --build-script build:mainnet",
"publish:mainnet:minor": "npm run publish:minor -- --environment mainnet --build-script build:mainnet",
"publish:mainnet:patch": "npm run publish:patch -- --environment mainnet --build-script build:mainnet"
"publish:mainnet:patch": "npm run publish:patch -- --environment mainnet --build-script build:mainnet",

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 11, 2019

Member

Super tiny nitpick: could we re-order these publish scripts as mainnet -> rinkeby -> staging -> ropsten to be in similar order to the build and start scripts?

@izqui izqui merged commit 271f097 into ropsten Jul 12, 2019

3 of 6 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Ready for review
Details
install install
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the ropsten-ens branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.