Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Badge and update occurrences for Tag #901

Open
wants to merge 3 commits into
base: newstyle-permissions
from

Conversation

@AquiGorka
Copy link
Member

commented Aug 2, 2019

DO NOT MERGE

Accompanying changes for removing Badge

Rebase, change base target, and merge after #899.

@AquiGorka AquiGorka requested a review from bpierre Aug 2, 2019

@AquiGorka AquiGorka force-pushed the newstyle-0.8/remove-badge branch from b801cdf to 8d4a13b Aug 2, 2019

src/apps/AppCenter/InstalledApps/RepoVersions.js Outdated Show resolved Hide resolved
src/components/AppInstanceLabel.js Outdated Show resolved Hide resolved
src/apps/AppCenter/DiscoverApps/DiscoverApps.js Outdated Show resolved Hide resolved
@Schwartz10 Schwartz10 referenced this pull request Aug 8, 2019

AquiGorka and others added some commits Aug 2, 2019

@sohkai sohkai changed the base branch from newstyle to newstyle-permissions Aug 18, 2019

@sohkai sohkai force-pushed the newstyle-0.8/remove-badge branch from 8d4a13b to b8debff Aug 18, 2019

@sohkai

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@AquiGorka I've updated this PR with the new Tag API and removed outdated styling.

@bpierre
Copy link
Member

left a comment

🎺

mode="new"
css={`
overflow: hidden;
text-overflow: ellipsis;

This comment has been minimized.

Copy link
@bpierre

bpierre Aug 18, 2019

Member

Maybe we should provide these two by default?

This comment has been minimized.

Copy link
@AquiGorka

AquiGorka Aug 19, 2019

Author Member

I hear you, and I've been thinking about it but I don't know, it seems the simplicity of Tag might be over engineered, then again, if we find that this is always the case it would make sense to provide these by default.

src/apps/AppCenter/InstalledApps/AppCardContent.js Outdated Show resolved Hide resolved
AppCardContent: use GU instead of raw values
Co-Authored-By: Pierre Bertet <hello@pierre.world>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.