Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Scout opt-out fix #905

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@AquiGorka
Copy link
Member

commented Aug 9, 2019

These changes also include the new help color for the help scout button:

image

@AquiGorka AquiGorka requested review from bpierre and sohkai Aug 9, 2019

@luisivan luisivan referenced this pull request Aug 9, 2019
31 of 55 tasks complete
@sohkai

sohkai approved these changes Aug 9, 2019

Copy link
Member

left a comment

👍 LGTM, can confirm it fixes the bug.

@AquiGorka AquiGorka merged commit 19eec61 into newstyle Aug 12, 2019

4 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
install install
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@delete-merged-branch delete-merged-branch bot deleted the newstyle-0.8/helpscout-optout-fix branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.