Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignerPanel: fix error cases when Ethereum provider doesn't error with message #906

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@sohkai
Copy link
Member

commented Aug 11, 2019

Unclear which providers error in this way, but we were erroneously making the assumption that an error thrown from the provider would always contain a message string.

See https://sentry.io/share/issue/54450fea43c74f0e86d2ca4a332121d8/ for an example.

Adds a new message to point the user at something wrong going on with their signing provider in such cases:

Screen Shot 2019-08-12 at 12 07 24 AM

@auto-assign auto-assign bot requested review from AquiGorka and bpierre Aug 11, 2019

@bpierre
Copy link
Member

left a comment

Nice find! 🙌

@sohkai sohkai merged commit ae019f7 into newstyle Aug 11, 2019

5 of 9 checks passed

lint lint
Details
build build
Details
install install
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-signing-error branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.