Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Org: fix upgrade transaction for orgs with non-known apps #977

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 8, 2019

Oops 馃檲, if you had more than just the known apps installed and there were major updates available for them, this would try to also include them in the upgrade.

This now selects only the short list of known repos (Finance, Tokens, Voting) to be part of this "organization upgrade".

Fixes some bugs with the upgrade panel along with aragon/aragon.js#385.

Upgrade Organization: fix upgrade organization transaction for organi鈥
鈥ations with more than just known repos installed

@auto-assign auto-assign bot requested review from AquiGorka and bpierre Sep 8, 2019

@bpierre
bpierre approved these changes Sep 8, 2019

@sohkai sohkai changed the title Upgrade Organization: fix upgrade organization transaction for organizations with more than just known repos installed Upgrade Org: fix upgrade transaction for orgs with non-known apps Sep 8, 2019

@sohkai sohkai merged commit c3a17aa into master Sep 8, 2019

9 checks passed

build build
Details
install install
Details
lint lint
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@sohkai sohkai deleted the fix-upgrade-organization-panel branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.