Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourite Organizations: check address equality with checksums included #985

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 9, 2019

I'm surprised we've gotten away for so long without doing this in FavoritesDao.

Fixes the issue with seeing duplicates in the org switcher and onboarding's suggestions list.

sohkai added 2 commits Sep 9, 2019

@sohkai sohkai requested a review from bpierre Sep 9, 2019

@auto-assign auto-assign bot requested a review from AquiGorka Sep 9, 2019

@bpierre
bpierre approved these changes Sep 9, 2019
Copy link
Member

left a comment

💯 🙏 💯 🙏 💯

@sohkai sohkai changed the title Favourite Organizations: check address equality with checksums in mind Favourite Organizations: check address equality with checksums included Sep 9, 2019

@sohkai sohkai merged commit fa645d4 into onboarding2 Sep 9, 2019

9 checks passed

build build
Details
install install
Details
lint lint
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@sohkai sohkai deleted the favorites-address-checksum branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.