Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: small PR changes #986

Merged
merged 13 commits into from Sep 9, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 9, 2019

Fixes some small comments made in the original PR.

@sohkai sohkai requested a review from bpierre Sep 9, 2019

@auto-assign auto-assign bot requested a review from AquiGorka Sep 9, 2019

@bpierre
bpierre approved these changes Sep 9, 2019
Update src/components/Carousel/PrevNext.js
Co-Authored-By: Pierre Bertet <hello@pierre.world>
sohkai added 3 commits Sep 9, 2019
sohkai added 4 commits Sep 9, 2019
@@ -220,7 +220,7 @@ function Onboarding({

Onboarding.propTypes = {
account: EthereumAddressType,
status: PropTypes.string.isRequired,
status: PropTypes.oneOf(['none', 'welcome', 'open', 'create']).isRequired,

This comment has been minimized.

Copy link
@bpierre
@bpierre
bpierre approved these changes Sep 9, 2019

@sohkai sohkai merged commit 76d9e3c into onboarding2 Sep 9, 2019

8 of 9 checks passed

build build
Details
install install
Details
lint lint
Details
License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@sohkai sohkai deleted the onboarding2-fixes branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.