Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: add app badges #996

Merged
merged 8 commits into from Sep 10, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 10, 2019

Screen Shot 2019-09-10 at 1 36 42 AM

Screen Shot 2019-09-10 at 1 36 55 AM

sohkai added 3 commits Sep 10, 2019

@sohkai sohkai requested a review from bpierre Sep 10, 2019

@auto-assign auto-assign bot requested a review from AquiGorka Sep 10, 2019

@bpierre
Copy link
Member

left a comment

❤️

sohkai added 3 commits Sep 10, 2019
@sohkai

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

Edit: reverted in 7acdb15 to change to the modal overlay being scrollable instead.

@bpierre I've added a few commits, but most important is ad0b53d, which avoids the template details modal from becoming too large for the screen. It now uses a max of 90vh:

Screen Shot 2019-09-10 at 2 51 12 AM

It's not great that the button is hidden under the fold... but perhaps we can rethink this later (perhaps moving the configuration into an accordion)?

@sohkai sohkai merged commit 0e0af86 into onboarding2 Sep 10, 2019

3 of 7 checks passed

install install
Details
License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
now Now is deploying your app
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the onboarding-app-badges branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.