Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences: update network settings' buttons to be fullwidth on small layouts #998

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 10, 2019

Screen Shot 2019-09-10 at 10 58 42 AM

@auto-assign auto-assign bot requested review from AquiGorka and bpierre Sep 10, 2019

@@ -29,6 +30,7 @@ function Network({ wrapper }) {
network,
} = useNetwork(wrapper)
const theme = useTheme()
const { layoutName } = useLayout()

This comment has been minimized.

Copy link
@AquiGorka

AquiGorka Sep 10, 2019

Member

I thought useLayout would not work in the client? cc @bpierre
Should this use useViewport instead?

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 10, 2019

Author Member

But we do declare Layout in the Preferences, as various components (e.g. Box, Split) need them.

@sohkai sohkai merged commit 42311d9 into master Sep 10, 2019

8 of 9 checks passed

build build
Details
install install
Details
lint lint
Details
License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details

@sohkai sohkai deleted the preferences-network-fullwidth-buttons branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.