Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AragonApp: provide initialize() function for subclasses to chain initialization blocks #531

Open
sohkai opened this issue Jun 7, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@sohkai
Copy link
Member

commented Jun 7, 2019

We could provide a default initialize() function as part of AragonApp that just calls initialized().

This would allow us to recommend all AragonApp subclasses to include an initialize() block that always invokes super.initialize() immediately (this is very similar to how React does component construction), greatly simplifying how contracts subclassed more than one level deep (e.g. Agent, fundraising's Pool) can define custom initialization behaviour.

From React's documentation:

When implementing the constructor for a React.Component subclass, you should call super(props) before any other statement.

cc @izqui @facuspagnuolo @osarrouy

@sohkai sohkai added the enhancement label Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.