Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to execute initialization payload on AppProxy deployment #148

Merged
merged 2 commits into from Nov 15, 2017

Conversation

@izqui
Copy link
Member

izqui commented Nov 14, 2017

Closes #144

Adds the ability to provide a payload to be executed when an AppProxy is deployed. This allows to perform an atomic deployment and initialization of any app without the need to have a specific factory.

It shouldn't introduce any security vulnerabilities as the proxy will forward any call in the same way after it being deployed.

TODO: Needs documentation update on the wiki

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 14, 2017

Coverage Status

Changes Unknown when pulling c8b617e on app-proxy-init into ** on dev**.

@izqui izqui requested a review from onbjerg Nov 14, 2017
@onbjerg

This comment has been minimized.

Copy link
Contributor

onbjerg commented Nov 14, 2017

The payload is just generic calldata? What happens if the calldata is malformed?

@izqui

This comment has been minimized.

Copy link
Member Author

izqui commented Nov 15, 2017

Yes. If it is malformed and the delegatecall fails, then it will revert.

I'm not too worried about the calldata not being an initialization payload, as right after the contract is deployed, it starts forwarding any data to the target contract with a delegatecall anyway.

@izqui izqui merged commit c259bc3 into dev Nov 15, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.699%
Details
@izqui izqui deleted the app-proxy-init branch Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.