Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ability to execute initialization payload on AppProxy deployment #148
Adds the ability to provide a payload to be executed when an AppProxy is deployed. This allows to perform an atomic deployment and initialization of any app without the need to have a specific factory.
It shouldn't introduce any security vulnerabilities as the proxy will forward any call in the same way after it being deployed.
TODO: Needs documentation update on the wiki
Yes. If it is malformed and the delegatecall fails, then it will revert.
I'm not too worried about the calldata not being an initialization payload, as right after the contract is deployed, it starts forwarding any data to the target contract with a delegatecall anyway.