New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delegate executors #324

Merged
merged 3 commits into from Jun 6, 2018

Conversation

Projects
None yet
3 participants
@sohkai
Member

sohkai commented May 25, 2018

Also removes related tests and size checks we added to the proxies in an attempt to make these executors safer.

TODO:

  • Remove docs

@sohkai sohkai requested review from izqui and bingen May 25, 2018

@@ -57,9 +52,7 @@ contract('EVM Script', accounts => {

This comment has been minimized.

@bingen

bingen May 25, 2018

Contributor

Shouldn't the "3" in the description for this test be changed to "1"?

})
})
context('script overflow', async () => {

This comment has been minimized.

@bingen

bingen May 25, 2018

Contributor

Why is this one being removed?

This comment has been minimized.

@sohkai

sohkai May 25, 2018

Member

Nice catch, this should stay :).

@bingen

bingen approved these changes May 25, 2018

@izqui

izqui approved these changes Jun 4, 2018

@sohkai sohkai merged commit be4522b into dev Jun 6, 2018

4 of 5 checks passed

License Compliance 1 issues found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.995%
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the remove-delegate-executors branch Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment