New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truffle migration async scripts #366

Merged
merged 1 commit into from Jul 24, 2018

Conversation

Projects
None yet
2 participants
@mnaamani
Copy link
Contributor

mnaamani commented Jul 23, 2018

Solves #365 using the pattern seen here: trufflesuite/truffle#501

@sohkai

sohkai approved these changes Jul 24, 2018

Copy link
Member

sohkai left a comment

🎉

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Jul 24, 2018

Thanks @mnaamani, it looks like this was working for us out of luck, or something with how node timeouts.

The new migration logs look much better (was always puzzled before why they seemed to be out of order).

Will have to remember this trick for our other migrations.

@sohkai sohkai merged commit e98b67c into aragon:dev Jul 24, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai referenced this pull request Jul 24, 2018

Closed

Truffle Migration Failure #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment