New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the owner of the TLD is the APMRegistryFactory itself before setSubnodeOwner #418

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
3 participants
@eduadiez
Copy link
Contributor

eduadiez commented Sep 4, 2018

Verify that the owner of the TLD is the APMRegistryFactory itself before setSubnodeOwner is invoked.

The ENS.sol from lib has the modifier only_owner that throws in case setSubnodeOwner is invoked by someone who isn't the owner.

However it seems that this isn't the behavior of the ENS-Registry (0x314159265dD8dbb310642f98f50C066173C1259b) which doesn't make a throw/revert. It returns a "Bad jump destination" so it won't refund the remaining gas

Verify that the owner of the TLD is the APMRegistryFactory itself
Verify that the owner of the TLD is the APMRegistryFactory itself when setSubnodeOwner is invoked
@izqui

izqui approved these changes Sep 4, 2018

@izqui izqui merged commit c22c154 into aragon:dev Sep 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 4, 2018

Coverage Status

Coverage decreased (-0.2%) to 98.916% when pulling 003358e on eduadiez:dev into 7fca564 on aragon:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment