New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KernelConstants: use nonstrict pragma #436

Merged
merged 2 commits into from Oct 8, 2018

Conversation

Projects
None yet
5 participants
@0mkara
Copy link
Contributor

0mkara commented Oct 4, 2018

Use non-strict version to be able to import aragon contracts on Remix & Etheratom.

KernelConstants is eventually used by AragonApp.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 4, 2018

Coverage Status

Coverage remained the same at 98.915% when pulling 9e54e01 on 0mkara:dev into f41bbfc on aragon:dev.

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Oct 7, 2018

@0mkara Please see #233 (comment) and #158 (comment) on rationale for why we've pinned the pragmas for some contracts.

You can change the compiler version in Remix by going to the compiler options:

image

@sohkai sohkai closed this Oct 7, 2018

@0mkara

This comment has been minimized.

Copy link
Contributor

0mkara commented Oct 7, 2018

@sohkai I was importing AragonApp.sol. Thing is currently both RemixIDE & EtheratomIDE both selects one version of solidity before they compile. So if a solidity program has different versions used by its imported contracts compilation fails.

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Oct 8, 2018

@0mkara Ahh shoot, yes you're right. Somehow we missed unpinning KernelConstants! Thanks for finding this 🙏

@sohkai sohkai reopened this Oct 8, 2018

@sohkai sohkai changed the title use nonstrict version KernelConstants: use nonstrict pragma Oct 8, 2018

@izqui

izqui approved these changes Oct 8, 2018

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Oct 8, 2018

@0mkara I've just added our MIT licensing to the unpinned files :).

@sohkai sohkai merged commit f67fa5d into aragon:dev Oct 8, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment