Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize mocks and test files #517

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented Apr 30, 2019

Simply organizing a bit the mock contract files and test files to follow the same directories structure we have under contracts/

@facuspagnuolo facuspagnuolo changed the base branch from dev to master Apr 30, 2019

@facuspagnuolo facuspagnuolo self-assigned this Apr 30, 2019

@sohkai sohkai changed the base branch from master to dev May 2, 2019

@sohkai

sohkai approved these changes May 2, 2019

Copy link
Member

left a comment

LGTM!

@facuspagnuolo We have kind of an "unwritten" branch rule (see https://forum.aragon.org/t/documenting-the-git-branch-convention-on-smart-contract-repos/599) for this repo, where dev is the default branch. master is only merged to after larger contract releases.

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Sure @sohkai, I wrongly branched from master, rebase on top of dev and merge, thx!

@facuspagnuolo facuspagnuolo force-pushed the organize_mocks_and_test_files branch from b435525 to f65c1b9 May 2, 2019

@coveralls

This comment has been minimized.

Copy link

commented May 2, 2019

Coverage Status

Coverage remained the same at 99.542% when pulling f65c1b9 on organize_mocks_and_test_files into 635dd96 on dev.

@facuspagnuolo facuspagnuolo merged commit 7052952 into dev May 2, 2019

5 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.542%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the organize_mocks_and_test_files branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.