Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Kill switch: Polish and integrate MVP version #518
Follow up on #516
Based on an offline discussion we had about the next-steps regarding the kill-switch topic, we decided to:
2 times, most recently
May 1, 2019
OTOH, I've been exploring many different edge cases about recoverability, and unfortunately my conclusion is that we will need to keep working on further models to have a robust implementation. I filed an issue sharing my thoughts on the matter, feel free to comment and leave feedback there.
However, based on the last changes, I think we can are pretty to close to have a full MVP version of the kill-switch, we just need to decide the which will be the MVP version of the recoverability process. IMO, I think we can do something with the voting app similar to what I did in 7f73ac3, please follow-up in the issue mentioned above.
sohkai left a comment •
There's a bunch of really small comments in this review, but the main ones I'd like to bring up: