Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic: re-organize some library tests #519

Merged
merged 3 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@sohkai
Copy link
Member

commented May 3, 2019

@facuspagnuolo Didn't notice this in #517, but a few proposed changes:

  • SafeERC20 tests: thought it'd be more consistent if they were moved to the test/common/ folder since it's a contracts/common/ contract
  • Uint256Helper tests: removed the lib_ prefix, as we don't use it elsewhere; do you think it's more clear if we have something designating libraries? I think a _lib suffix might work nicer as it's usually easier to scan if the name of the contract comes first.

sohkai added some commits May 3, 2019

@sohkai sohkai requested a review from facuspagnuolo May 3, 2019

@facuspagnuolo
Copy link
Contributor

left a comment

Sounds good! You'll probably need to fix the safe_erc20.js imports path as well

@coveralls

This comment has been minimized.

Copy link

commented May 3, 2019

Coverage Status

Coverage remained the same at 99.542% when pulling 9a6f891 on move-safeerc20-tests into 7052952 on dev.

@sohkai sohkai merged commit 9071a60 into dev May 3, 2019

5 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.542%
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the move-safeerc20-tests branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.