Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers: Fix assert revert helper #522

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented May 7, 2019

The assertRevert helper was using the actual and expected values swapped. This was causing misleading logs while testing an unsuccessful scenario.

@facuspagnuolo facuspagnuolo requested a review from sohkai May 7, 2019

@facuspagnuolo facuspagnuolo self-assigned this May 7, 2019

@coveralls

This comment has been minimized.

Copy link

commented May 7, 2019

Coverage Status

Coverage remained the same at 99.542% when pulling 614dab2 on fix_assert_revert_helper into 9071a60 on dev.

@sohkai

sohkai approved these changes May 7, 2019

Copy link
Member

left a comment

👍 I never know which one to put first in assertions 😅

@facuspagnuolo facuspagnuolo merged commit 98e5e79 into dev May 7, 2019

5 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.542%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the fix_assert_revert_helper branch May 7, 2019

bingen added a commit to aragon/aragon-court that referenced this pull request May 21, 2019

Restore error description for assertRevert
It's fixed here: aragon/aragonOS#522
(Until it's released `npm link @aragon/os is needed for coverage`)

bingen added a commit to aragon/aragon-court that referenced this pull request May 22, 2019

Restore error description for assertRevert
It's fixed here: aragon/aragonOS#522
(Until it's released `npm link @aragon/os is needed for coverage`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.