Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add DAO factory unit tests #524

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented May 8, 2019

No description provided.

@facuspagnuolo facuspagnuolo requested a review from sohkai May 8, 2019

@facuspagnuolo facuspagnuolo self-assigned this May 8, 2019

@sohkai

sohkai approved these changes May 8, 2019

Copy link
Member

left a comment

❤️ ❤️ ❤️

We were implicitly testing the DAOFactory in other tests previously, but having this explicit one is much needed!

@coveralls

This comment has been minimized.

Copy link

commented May 8, 2019

Coverage Status

Coverage remained the same at 99.542% when pulling 943ecca on add_dao_factory_tests into 98e5e79 on dev.

@facuspagnuolo facuspagnuolo merged commit 220b6b1 into dev May 8, 2019

5 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.542%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the add_dao_factory_tests branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.