Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License: replace SPDX-Identifier misspelling in contract headers #558

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@ottodevs
Copy link
Contributor

commented Oct 2, 2019

Even though it was fun to spot projects reusing or forking aragon contracts: https://github.com/search?q=SPDX-License-Identitifer&type=Code

But I thought it might be interesting to fix the misspelling, in case any automated script might eventually parse that header to show the license.

Related: aragon/aragon-apps#1013

@welcome

This comment has been minimized.

Copy link

commented Oct 2, 2019

Thanks for opening this pull request! Someone will review it soon 🔍

@coveralls

This comment has been minimized.

Copy link

commented Oct 2, 2019

Coverage Status

Coverage remained the same at 99.116% when pulling f07ae44 on ottodevs:identitifer-fix into 0fd1ff6 on aragon:next.

@sohkai
sohkai approved these changes Oct 4, 2019
Copy link
Member

left a comment

😅 That's one copy pasta gone unnoticed for far too long!

Good catch @ottodevs!

@sohkai sohkai changed the title Replace Identifier misspelling in license headers License: replace SPDX-Identifier misspelling in contract headers Oct 4, 2019
@sohkai sohkai merged commit 07d309f into aragon:next Oct 4, 2019
5 checks passed
5 checks passed
Gas Usage Gas usage increased for 7 items and decreased for 17 items
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.116%
Details
license/cla Contributor License Agreement is signed.
Details
@welcome

This comment has been minimized.

Copy link

commented Oct 4, 2019

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.