Webworker in iframe

[AquiGorka]

Adds extra sandboxing to webworkers by executing them in iframe.

[bpierre]

Looking good! We should also provide a way to clean the things created by this class (event listener and injected element). Did you notice any change in terms of performances?

[AquiGorka]

We should also provide a way to clean the things created by this class (event listener and injected element).

Done. 😄

Did you notice any change in terms of performances?

Did not do any benchmark nor profiling, locally feels the same, did load anv and it worked fast. We should ask @sohkai to perform the tests he was doing in the experiments here to see if this affects performance.

[2color]

LGTM. I tested and there were no noticeable performance regressions.

[2color]

@AquiGorka One last question, who calls terminate?

[AquiGorka]

@2color :

Update, this is the correct one: https://github.com/aragon/aragon/blob/ee6853f3c159d40e51611830454586663fd080ae/src/worker-utils.js#L61

[bpierre]

@AquiGorka One last question, who calls terminate?

We should call it from here: https://github.com/aragon/aragon/blob/feature/webworker-in-iframe/src/aragonjs-wrapper.js#L405

So that it gets cleaned when needed: https://github.com/aragon/aragon/blob/feature/webworker-in-iframe/src/App.js#L199

Loading another DAO probably doesn’t work in the current state?

Edit: oh right, I missed that @AquiGorka

[bpierre]

💯