Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust template #72

Merged
merged 19 commits into from Jul 3, 2019

Conversation

Projects
None yet
4 participants
@facuspagnuolo
Copy link
Contributor

commented May 28, 2019

This PRs aims to provide a new DAO kit to implement Aragon trust entities.

@facuspagnuolo facuspagnuolo force-pushed the facuspagnuolo:trust_template branch 3 times, most recently from 32e7c0f to 4c9f81c May 29, 2019

@facuspagnuolo facuspagnuolo changed the title [WIP] Trust template Trust template May 31, 2019

@luisivan luisivan referenced this pull request May 31, 2019

Closed

Create template for Aragon Trust #114

6 of 6 tasks complete

@facuspagnuolo facuspagnuolo force-pushed the facuspagnuolo:trust_template branch 6 times, most recently from 78f18c5 to 69f34e0 Jun 1, 2019

@facuspagnuolo facuspagnuolo requested a review from izqui Jun 3, 2019

@facuspagnuolo facuspagnuolo self-assigned this Jun 3, 2019

@facuspagnuolo facuspagnuolo requested a review from bingen Jun 4, 2019

@bingen

bingen approved these changes Jun 12, 2019

Copy link
Member

left a comment

This is cool and huge! Good job!!

Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved kits/agp1/scripts/deploy_agp1.js Outdated
Show resolved Hide resolved kits/beta-base/test/docker.js
Show resolved Hide resolved kits/democracy/test/democracy.js
Show resolved Hide resolved kits/multisig/test/multisig.js
Show resolved Hide resolved kits/trust/contracts/TrustKit.sol
Show resolved Hide resolved kits/trust/contracts/TrustKit.sol Outdated
Show resolved Hide resolved kits/trust/contracts/TrustKit.sol
Show resolved Hide resolved kits/trust/contracts/TrustKit.sol
Show resolved Hide resolved kits/trust/test/trust.js Outdated

@facuspagnuolo facuspagnuolo force-pushed the facuspagnuolo:trust_template branch from eeefc4e to 2c7461c Jun 13, 2019

if (reason.lentgh === 0) return true
const response = await web3.eth.call(tx)
const reasonFound = decodeReason(response)
assert.equal(reasonFound, reason, `Revert reason '${reason}' not found. Found '${reasonFound}' instead.` )

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 3, 2019

Member

Nice trick to get the revert reason! I never knew you could do this haha!

I'm wondering if it would make sense for us to detect somehow that we're running on ganache / geth, so we could create a generic version of this utility? I'd really like to split the @aragon/test-helpers out and use it everywhere :).

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Jul 3, 2019

Author Contributor

Sure, I think it'd be possible :)

trust: fix assert revert helper typo
Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>

@facuspagnuolo facuspagnuolo merged commit b1a6a41 into aragon:master Jul 3, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the facuspagnuolo:trust_template branch Jul 3, 2019

facuspagnuolo added a commit that referenced this pull request Jul 3, 2019

Trust template (#72)
* base: adapt beta-base kit to support agent app

* trust: setup new kit for trust entities

* trust: implement new trust kit

* trust: add trust kit deployment scripts

* trust: test trust kit contract

* trust: add task to travis config file

* trust: copy multisig contract and remove git dep

* base: add agent app dependency

* trust: fix beta-base kit tests

* trust: add network to trust-deploy script

* trust: fix multi sig setup

* trust: add arapp file with rinkeby deploy

* trust: add creation script

* trust: improve create script to calculate heirs stake

* trust: minor improvements based on @bingen's review

* trust: fix agent permissions for heirs

* chore: extend dependencies install to 60 min

* chore: upgrade travis node to v9

* trust: fix assert revert helper typo

Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.