Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Deploy to rinkeby and ropsten #129

Merged
merged 21 commits into from Aug 14, 2019

Conversation

@facuspagnuolo
Copy link
Member

commented Aug 9, 2019

No description provided.

@facuspagnuolo facuspagnuolo requested a review from sohkai Aug 9, 2019

@facuspagnuolo facuspagnuolo self-assigned this Aug 9, 2019

templates/reputation/arapp.json Outdated Show resolved Hide resolved
@sohkai

sohkai approved these changes Aug 10, 2019

},
"rinkeby": {
"appName": "company-template.aragonpm.eth",
"address": "0xe8a5694c9ae3fc73a32e333c3b7b27ccb9a7d2cd",

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 13, 2019

Member

Ahh, we don't need to keep the address here since it's available from the repo attached to appName.

Also, it looks like these addresses were deployed before the new DAOFactory (0x137676c1941c8b12d18b12eb2215d1361aee20e0) was deployed; could we redeploy using the deploy:staging commands again?

"deploy:ropsten": "npm run compile && truffle exec ./scripts/deploy.js --network ropsten --ens 0x6afe2cacee211ea9179992f89dc61ff25c61e923",
"deploy:staging": "npm run compile && truffle exec ./scripts/deploy.js --network rinkeby --ens 0xfe03625ea880a8cba336f9b5ad6e15b0a3b5a939 --dao-factory 0x137676c1941c8b12d18b12eb2215d1361aee20e0 --mini-me-factory 0xc31d4145ca14227b2d780dd51cea0923dae609da",
"deploy:rinkeby": "npm run compile && truffle exec ./scripts/deploy.js --network rinkeby --ens 0x98Df287B6C145399Aaa709692c8D308357bC085D --dao-factory 0x137676c1941c8b12d18b12eb2215d1361aee20e0 --mini-me-factory 0xc31d4145ca14227b2d780dd51cea0923dae609da",
"deploy:ropsten": "npm run compile && truffle exec ./scripts/deploy.js --network ropsten --ens 0x6afe2cacee211ea9179992f89dc61ff25c61e923 --dao-factory 0x56aee4a6e24e36fa6dc653d81dfdf76aa149f774 --mini-me-factory 0xc841c1b35bdc8f7c35b7703cd797525143069fbb",

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 13, 2019

Member

For Rinkeby and Ropsten, can we use the same DAOFactory and MiniMeTokenFactory addresses as 0.7?

  • Rinkeby:
    • DAOFactory: 0xfdef49fbfe37704af55636bdd4b6bc8cd19143f6
    • MiniMeTokenFactory: 0x6ffeb4038f7f077c4d20eaf1706980caec31e2bf
  • Ropsten:
    • DAOFactory: 0x3f2aa9dd22e97070518ba7988fe9b8724129d497
    • MiniMeTokenFactory: 0x1ce5621d386b2801f5600f1dbe29522805b8ac11

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 13, 2019

Member
  • Staging:
    • DAOFactory: 0xbca2c99aa7018edcde60e6c5744f68003112535d
    • MiniMeTokenFactory: 0xac443f983c38c02149ce2ffcff8b7de90dccf77c
  • Mainnet:
    • DAOFactory: 0xc29f0599df12eb4cbe1a34354c4bac6d944071d1
    • MiniMeTokenFactory: 0x909d05f384d0663ed4be59863815ab43b4f347ec

@facuspagnuolo facuspagnuolo force-pushed the deploy_to_testnet branch from e79bb5b to 3cccd96 Aug 14, 2019

@facuspagnuolo facuspagnuolo merged commit 0dff3f5 into master Aug 14, 2019

4 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the deploy_to_testnet branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.