Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `@aragon/templates-shared` to be published #131

Merged
merged 7 commits into from Aug 14, 2019

Conversation

@sohkai
Copy link
Member

commented Aug 12, 2019

Adds npm configuration to shared/ so we can publish it :).

sohkai added some commits Aug 12, 2019

@sohkai sohkai requested a review from facuspagnuolo Aug 12, 2019

@sohkai sohkai force-pushed the publish-templates-shared branch from 09c12ff to a1fdfa6 Aug 12, 2019

"helpers/",
"lib/",
"scripts/",
".env",

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 12, 2019

Author Member

I'm not really sure I understand the need for the .env file. I see we use ETHDATA_LOCAL_PATH in the docker-compose file, but does that get automatically injected by docker?

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Aug 12, 2019

Member

We shouldn't add it here definitely. It is used by dotenv which we already dropped, so we don't need it here.
I don't see why adding ethereum-data and docker-compose.yml, these completely custom to our testing task.

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 12, 2019

Author Member

But we're sharing the testing utils with others; do you think it'd be useful if they had these geth-helpers too (like we do in our templates)?


And so can we remove the .env file? How does the docker-compose get the env var if we're not using dotenv anymore?

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Aug 12, 2019

Member

Now you're asking, yea, it's weird... maybe it is being injected by docker as you were saying

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved

sohkai and others added some commits Aug 13, 2019

Update readme.md
Co-Authored-By: Jorge Izquierdo <jorge@aragon.one>
Update readme.md
Co-Authored-By: Jorge Izquierdo <jorge@aragon.one>

@sohkai sohkai changed the title Publish `@aragon/templates-shared` Allow `@aragon/templates-shared` to be published Aug 14, 2019

@sohkai sohkai merged commit a7a376b into master Aug 14, 2019

4 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the publish-templates-shared branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.