Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit review 6.4: All finance roles to board #144

Merged
merged 4 commits into from Sep 2, 2019

Conversation

@ajsantander
Copy link
Contributor

commented Aug 29, 2019

Problem:

The board has most of the important permissions on Finance, but doesn't have minor permissions that would allow them to execute scheduled payments and cancel them, which could be annoying. Additionally, shareholders have too many Finance permissions when these could be considered "executive" roles.

Solution:

Remove Finance roles from shareholders and assign all of them to the board.

Audit issue:

https://github.com/aragonone/aragon-daotemplates-audit-report-2019-08#64-company-board---inconsistent-permissions-in-finance-application

@ajsantander ajsantander requested review from lkngtn and facuspagnuolo Aug 29, 2019

@ajsantander ajsantander changed the base branch from master to audit Aug 29, 2019

@ajsantander ajsantander force-pushed the audit_6.4 branch from 9a5828d to 00924d9 Aug 29, 2019

@lkngtn

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

LGTM 👍

@lkngtn
lkngtn approved these changes Sep 2, 2019

@ajsantander ajsantander merged commit bc93fde into audit Sep 2, 2019

4 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the audit_6.4 branch Sep 2, 2019

facuspagnuolo added a commit that referenced this pull request Sep 3, 2019
Audit review 6.4: All finance roles to board (#144)
* Removed finance roles from shareholders and assign to board

* Removed redundant function from board template
facuspagnuolo added a commit that referenced this pull request Sep 4, 2019
Audit review 6.4: All finance roles to board (#144)
* Removed finance roles from shareholders and assign to board

* Removed redundant function from board template
facuspagnuolo added a commit that referenced this pull request Sep 4, 2019
Audit review 6.4: All finance roles to board (#144)
* Removed finance roles from shareholders and assign to board

* Removed redundant function from board template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.